quantiom/AdvancedVanish

[Bug] Vanished users can be messaged.

ItzSave opened this issue · 8 comments

When a user is in vanish they can still be private messaged which makes the vanished status pointless.

Version: 1.18.2
Related Plugins: Essentials, VentureChat
AdvancedVanish Version: 1.1.3

Hi, I could not reproduce this with the VentureChat plugin.

When vanished:
image

When not vanished:
image

The problem is /msg . When in a vanished state users can still do that to message them and see if they are online or not.

Hi, can you please show a picture of what you mean? Thanks.

To recreate:

  • Enter /vanish on an account.
  • Have another account without permission to see vanished users.
  • The default account should use /msg "vanished player's name"

Expected Behavior:

  • Default user should not be able to message the vanished users should return a user is offline message.

Any further updates on this?

I believe this is an issue with the VentureChat plugin. The if statement here only checks if the player is online instead of also checking if the other player can see them (if they are in vanish): https://github.com/Aust1n46/VentureChat/blob/38746624d931365fa790b655b7caf6083bf9ba55/src/main/java/mineverse/Aust1n46/chat/listeners/ChatListener.java#L79.

Should I make an issue on their page and see what if anything can be done?

Yes