quantopian/trading_calendars

XFRA incorrect times?

ardita96 opened this issue · 2 comments

Hi there,
It seems the XFRA closing time is incorrect, it is 20:00 CET.
https://www.tradinghours.com/exchanges/fsx

Looks like the opening hours for XETR is those that are implemented. Here is the official source: https://www.xetra.com/xetra-en/trading/trading-calendar-and-trading-hours

XFRA opens 08:00 and closes 20:00 CET for most products.

If XFRA is changed, I think XETR should be added with 09:00-17:30 CET and same calendar.

Besides the issue with the regular business hours, the closing time for the special close on 30th December seems to be incorrect as well, regardless of whether you consider XFRA or XETR.

Consider e.g. the official announcement for 2019 according to which XETR closed the regular session at 14:00 CET (with a post-trading phase until 15:00 CET) and XFRA closed at 15:00 CET. The time returned by the respective calendar in the package at version 1.11.8 is 12:30 CET.

So it would appear that the special close time for XFRA should be 15:00 CET and 14:00 CET for XETR since the post-trading phase is typically not considered.

Also of note is that this special close is decided upon every year again, so to be 100% accurate, one would have watch out for the official announcement in December and update the code in case the expected special times don't apply.

I would suggest to add XETR as this would allow to fix the times for good. Otherwise, you'll always be breaking one or the other.

BTW: The Turquoise Trading Calendar also lists the 2020 special close time on 30th December for XETR as 13:00 London time which corresponds to 14:00 CET.