quantumiracle/Popular-RL-Algorithms

Issue in test mode of 'sac_v2_gru.py'

hynkis opened this issue · 1 comments

Hi, thank you for your awesome GRU based SAC!
I found that from the line 303 to 304 in 'sac_v2_gru.py' should be modified as it is GRU implementation.

Location :
https://github.com/quantumiracle/SOTA-RL-Algorithms/blob/9856600d19f2ed787094f7a968e8588cfead1a21/sac_v2_gru.py#L303

Modification:

        # hidden_out = (torch.zeros([1, 1, hidden_dim], dtype=torch.float).cuda(), \
        #     torch.zeros([1, 1, hidden_dim], dtype=torch.float).cuda())  # initialize hidden state for lstm, (hidden, cell), each is (layer, batch, dim)             
        hidden_out = torch.zeros([1, 1, hidden_dim], dtype=torch.float).cuda()

Thanks!

Hi,
Thanks for pointing out!
It's fixed!