quarkiverse/quarkus-pact

Allow pact classloading configuration to be removed from quarkus core by having it here

Closed this issue · 1 comments

holly-cummins commented

This is something we want to think about. The main Quarkus product declares some pact libraries to be parentFirst.

Should we move all that configuration over here? It would mean the extension was required for pact, but would make the main codebase tidier.

       <!-- Pact[<4.1.0] support. It would be great if there was somewhere better to put this-->
                        <parentFirstArtifact>au.com.dius:pact-jvm-provider-junit5</parentFirstArtifact>
                        <parentFirstArtifact>au.com.dius:pact-jvm-provider</parentFirstArtifact>
                        <parentFirstArtifact>au.com.dius:pact-jvm-core-support</parentFirstArtifact>
                        <parentFirstArtifact>au.com.dius:pact-jvm-core-pact-broker</parentFirstArtifact>
                        <parentFirstArtifact>au.com.dius:pact-jvm-core-model</parentFirstArtifact>
                        <parentFirstArtifact>au.com.dius:pact-jvm-core-matchers</parentFirstArtifact>
                        <parentFirstArtifact>au.com.dius:pact-jvm-junit5</parentFirstArtifact>
                        <parentFirstArtifact>au.com.dius:pact-jvm-consumer-java8</parentFirstArtifact>
                        <parentFirstArtifact>au.com.dius:pact-jvm-consumer</parentFirstArtifact>
                        <!-- Pact[>=4.1.0] support.-->
                        <parentFirstArtifact>au.com.dius.pact.provider:junit5</parentFirstArtifact>
                        <parentFirstArtifact>au.com.dius.pact:provider</parentFirstArtifact>
                        <parentFirstArtifact>au.com.dius.pact.core:support</parentFirstArtifact>
                        <parentFirstArtifact>au.com.dius.pact.core:pactbroker</parentFirstArtifact>
                        <parentFirstArtifact>au.com.dius.pact.core:model</parentFirstArtifact>
                        <parentFirstArtifact>au.com.dius.pact.core:matcher</parentFirstArtifact>
                        <parentFirstArtifact>au.com.dius.pact.consumer:junit5</parentFirstArtifact>
                        <parentFirstArtifact>au.com.dius.pact:consumer</parentFirstArtifact>
holly-cummins commented

Resolved by #30230.