Suggest strings.Contains instead of strings.ContainsAny for search of 1 char

Question

Suggest strings.Contains instead of strings.ContainsAny for search of 1 char

quasilyte opened this issue 3 years ago · 2 comments

This may sound silly, but it's easy to implement.
The underlying issue is that ContainsAny is not always a fast choice.
See https://github.com/golang/go/issues/31321
TODO: do the actual benchmarking.

Answer 1 · 2022-02-03T13:55:45.000Z

Why not suggest strings.ContainsRune?

Answer 2 · 2022-02-03T14:27:59.000Z

I think initially I was concerned about this case: strings.ContainsAny(s, "ab") vs 2 calls of ContainsRune or one manually written loop, like in the referenced issue.