quickwit-oss/quickwit

Setting some bool env vars to `"0"` or `"false"` evaluates to `true`

Closed this issue · 1 comments

guilload commented

We tend to use this pattern, which evaluates to true for any value as long as the en var is set, but sometimes when users want to revert the behavior, they use the value 0 or false instead of unsetting, which does not do anything.

env::var::("QW_IS_*").is_ok()

The following en vars have this issue:

  • QW_S3_FORCE_PATH_STYLE_ACCESS
  • QW_DISABLE_TELEMETRY
  • QW_ENABLE_INGEST_V2
  • QW_DISABLE_INGEST_V1
  • QW_DISABLE_DELETE_TASK_SERVICE

There might be more.

guilload commented

Closed via #5095.