python 3.11 support

Question

python 3.11 support

quillcraftsman opened this issue a year ago · 25 comments

We use inspect.getargspec in many modules. It's not working with python 3.11. It was deprecated since 3.3 python version.

Make it works on python 3.11
Run tests for python 3.10 and python 3.11
Use tests in GitHub actions on 3.10 and 3.11
Change in readme and on website.

Answer 1 · 2023-09-03T20:56:40.000Z

Roger that

Answer 2 · 2023-09-03T21:22:54.000Z

During build, I get a slight error:

Extracting lava_cactus-1.1.2-py3.11.egg to f:\webnprog\pythons\lavacactus\.env\lib\site-packages
  File "f:\webnprog\pythons\lavacactus\.env\lib\site-packages\lava_cactus-1.1.2-py3.11.egg\cactus\skeleton\plugins\haml.disabled.py", line 42
    print path
    ^^^^^^^^^^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)?

  File "f:\webnprog\pythons\lavacactus\.env\lib\site-packages\lava_cactus-1.1.2-py3.11.egg\cactus\tests\data\skeleton\plugins\haml.disabled.py", line 42
    print path
    ^^^^^^^^^^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)?

The builds works good, so I don't know if this is significant or not

Answer 3 · 2023-09-04T05:46:15.000Z

BTW, can someone tell me what's happening here,
plugin\manager.py:

    def preBuildPage(self, site, page, context, data):
        """
        Special call as we have changed the API for this.

        We have two calling conventions:
        - The new one, which passes page, context, data
        - The deprecated one, which also passes the site (Now accessible via the page)
        """
        for plugin in self.plugins:
            # Find the correct calling convention
            new = [page, context, data]
            deprecated = [site, page, context, data]
            arg_lists = dict((len(l), l) for l in [deprecated, new])
            try:
                # Try to find the best calling convention
                n_args = len(getargspec(plugin.preBuildPage).args)
                # Just use the new calling convention if there's fancy usage of
                # *args, **kwargs that we can't control.
                arg_list = arg_lists.get(n_args, new)
            except NotImplementedError:
                # If we can't get the number of args, use the new one.
                arg_list = new

            # Call with the best calling convention we have.
            # If that doesn't work, then we'll let the error escalate.
            context, data = plugin.preBuildPage(*arg_list)

        return context, data

After I fixed the inspect.getargspec issue by using inspect.signature and then converting the values to previous format:

# Basically to format the code in previous way so it creates a facade that returned value is unchanged

class ArgumentInfo:
    def __init__(self, args, varargs, varkw, defaults):
        self.args = args
        self.varargs = varargs
        self.varkw = varkw
        self.defaults = defaults

def get_argument_info(spec):
    args = [param.name for param in spec.parameters.values()]
    varargs = None
    varkw = None
    defaults = ()
    for param in spec.parameters.values():
        if param.default != inspect.Parameter.empty:
            defaults += (param.default,)
    return ArgumentInfo(args, varargs, varkw, defaults)

When I go cactus build, I don't get deprecated error anymore but:

Traceback (most recent call last):
  File "F:\WebNProg\Pythons\lavacactus\.env\Scripts\cactus-script.py", line 33, in <module>
    sys.exit(load_entry_point('lava-cactus==1.1.2', 'console_scripts', 'cactus')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "F:\WebNProg\Pythons\lavacactus\.env\Lib\site-packages\lava_cactus-1.1.2-py3.11.egg\cactus\cli.py", line 162, in cli_entrypoint
    main(sys.argv[1:])
  File "F:\WebNProg\Pythons\lavacactus\.env\Lib\site-packages\lava_cactus-1.1.2-py3.11.egg\cactus\cli.py", line 158, in main
    ns.target(**kwargs)
  File "F:\WebNProg\Pythons\lavacactus\.env\Lib\site-packages\lava_cactus-1.1.2-py3.11.egg\cactus\cli.py", line 51, in build
    site.build()
  File "F:\WebNProg\Pythons\lavacactus\.env\Lib\site-packages\lava_cactus-1.1.2-py3.11.egg\cactus\site.py", line 307, in build
    self.build_with_translation()
  File "F:\WebNProg\Pythons\lavacactus\.env\Lib\site-packages\lava_cactus-1.1.2-py3.11.egg\cactus\site.py", line 295, in build_with_translation
    mapper(lambda p: p.build(), self.pages())
  File "F:\WebNProg\Pythons\lavacactus\.env\Lib\site-packages\lava_cactus-1.1.2-py3.11.egg\cactus\utils\helpers.py", line 64, in map_apply
    return list(map(fn, iterable))
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "F:\WebNProg\Pythons\lavacactus\.env\Lib\site-packages\lava_cactus-1.1.2-py3.11.egg\cactus\site.py", line 295, in <lambda>
    mapper(lambda p: p.build(), self.pages())
                     ^^^^^^^^^
  File "F:\WebNProg\Pythons\lavacactus\.env\Lib\site-packages\lava_cactus-1.1.2-py3.11.egg\cactus\page.py", line 116, in build
    data = self.render()  #TODO: This calls preBuild indirectly. Not great.
           ^^^^^^^^^^^^^
  File "F:\WebNProg\Pythons\lavacactus\.env\Lib\site-packages\lava_cactus-1.1.2-py3.11.egg\cactus\page.py", line 107, in render
    context, data = self.site.plugin_manager.preBuildPage(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "F:\WebNProg\Pythons\lavacactus\.env\Lib\site-packages\lava_cactus-1.1.2-py3.11.egg\cactus\plugin\manager.py", line 63, in preBuildPage
    context, data = plugin.preBuildPage(*arg_list)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: ContextPlugin.preBuildPage() takes 4 positional arguments but 5 were given

Answer 4 · 2023-09-04T07:41:27.000Z

Now 5 arguments has been send to preBuildPage. Debug arg_list to see the difference.

Answer 5 · 2023-09-04T07:43:03.000Z

The builds works good, so I don't know if this is significant or not

It's not a problem if build works. May be later we will fix it too.

Answer 6 · 2023-09-04T09:40:00.000Z

Now 5 arguments has been send to preBuildPage. Debug arg_list to see the difference.

Yeah currently I am almost to the root of the problem...

Answer 7 · 2023-09-04T09:54:12.000Z

Okay I've fixed the issue, are there any special guidelines on how to comment the changes or anything like that?

Answer 8 · 2023-09-04T10:25:06.000Z

Hey now when I do cactus build, it builds okay but I get:

/about.html: static resource does not exist: static/js/vendor/jquery-3.7.0.js
/about.html: static resource does not exist: static/js/vendor/bootstrap.js
/contact.html: static resource does not exist: static/js/vendor/jquery-3.7.0.js
/contact.html: static resource does not exist: static/js/vendor/bootstrap.js
/error.html: static resource does not exist: static/js/vendor/jquery-3.7.0.js
/error.html: static resource does not exist: static/js/vendor/bootstrap.js
/index.html: static resource does not exist: static/js/vendor/jquery-3.7.0.js
/index.html: static resource does not exist: static/js/vendor/bootstrap.js

is this normal?

Answer 9 · 2023-09-04T11:22:37.000Z

Hey now when I do cactus build, it builds okay but I get:

/about.html: static resource does not exist: static/js/vendor/jquery-3.7.0.js
/about.html: static resource does not exist: static/js/vendor/bootstrap.js
/contact.html: static resource does not exist: static/js/vendor/jquery-3.7.0.js
/contact.html: static resource does not exist: static/js/vendor/bootstrap.js
/error.html: static resource does not exist: static/js/vendor/jquery-3.7.0.js
/error.html: static resource does not exist: static/js/vendor/bootstrap.js
/index.html: static resource does not exist: static/js/vendor/jquery-3.7.0.js
/index.html: static resource does not exist: static/js/vendor/bootstrap.js

is this normal?

Yes, it is normal

Answer 10 · 2023-09-04T11:23:35.000Z

Okay I've fixed the issue, are there any special guidelines on how to comment the changes or anything like that?

I will see pull request and add some comments may be

Answer 11 · 2023-09-04T11:43:31.000Z

@hind-sagar-biswas , good job. Please check two comments: #11

Answer 12 · 2023-09-04T11:48:40.000Z

Sorry but I don't see any comments ececpt for:

This branch has no conflicts with the base branch
Only those with write access to this repository can merge pull requests.

Answer 13 · 2023-09-04T11:51:44.000Z

It supposed to be on conversation page (at the bottom) and on file changed page (near the code) in pull request: #11

Answer 14 · 2023-09-04T11:52:59.000Z

quillcraftsman commented a year ago

Answer 15 · 2023-09-04T11:56:32.000Z

This is what I see:

Answer 16 · 2023-09-04T11:57:11.000Z

Also I'll fix the probs

Answer 17 · 2023-09-04T12:09:44.000Z

Strange, should be. Anybody else, check the comment in pull request please

Answer 18 · 2023-09-04T12:12:03.000Z

Also, I already made the changes, please review

Answer 19 · 2023-09-04T12:19:50.000Z

Good, I've added another one

Answer 20 · 2023-09-04T12:23:28.000Z

Good, I've added another one

@quillcraftsman
LoL I still can't see any. I even tried to check from a logged-out browser, and it's the same there.

Answer 21 · 2023-09-04T13:37:51.000Z

@hind-sagar-biswas , try it again, may be I forgot to submit a review.

Answer 22 · 2023-09-04T14:26:52.000Z

@hind-sagar-biswas , try it again, may be I forgot to submit a review.

Yeah I replied the review @quillcraftsman

Answer 23 · 2023-09-05T08:56:42.000Z

@hind-sagar-biswas , pull request has been accepted, nice play. This issue contains also tests and readme, I will continue with its myself (want to realese with python 3.11 today). You are welcome to focuses on other issues

Answer 24 · 2023-09-05T09:47:33.000Z

Now lavacactus support 3.8-3.11 python version. All task have been done

Answer 25 · 2023-09-05T10:10:57.000Z

Done in new release 1.2.0