quisquous/cactbot

PR #5754 also flips Classical 1 column order

DreyfussFrost opened this issue · 1 comments

DreyfussFrost commented

Thanks for the work implementing the new Classical Concepts option! I'm glad to report it works perfectly for Classical 2, however, having the checkbox enabled also reverses the column order for Classical 1. When I tested it with BPOG order, I was given the instructions for G when I was B, or O when I was P, and so on. This only occurs during Classical 1. Classical 2 works as intended.

Demonstration: https://youtu.be/wNmS1kU8OLY

Originally posted by @DreyfussFrost in #5752 (comment)

wexxlee commented

implementing the new Classical Concepts option! I'm glad to report it works perfectly for Classical 2, however, having the checkbox enabled also reverses the column order for Classical 1. When I tested it with BPOG order, I was given the instructions for G when I was B, or O when I was P, and so on. This only occurs during Classical 1. Classical 2 works as intended.

Yeah, you're right. There should have been a phase check on columnOrder.reverse. Apologies for that - I'll drop a PR to fix ASAP.