qunitjs/node-qunit

Visible error, but tests pass anyway

mcandre opened this issue · 6 comments

Trace:

$ npm test

> qunit@0.5.16 test c:\Documents and Settings\apenneba\Desktop\src\node-qunit
> make test

node ./test/testrunner.js

Testing c:\Documents and Settings\apenneba\Desktop\src\node-qunit\test\fixtures\testrunner-code.js ... done
Testing c:\Documents and Settings\apenneba\Desktop\src\node-qunit\test\fixtures\child-code-global.js ... done
Testing c:\Documents and Settings\apenneba\Desktop\src\node-qunit\test\fixtures\testrunner-code.js ... done
Testing c:\Documents and Settings\apenneba\Desktop\src\node-qunit\test\fixtures\child-code-namespace.js ... done
Testing c:\Documents and Settings\apenneba\Desktop\src\node-qunit\test\fixtures\async-code.js ... done
Testing c:\Documents and Settings\apenneba\Desktop\src\node-qunit\test\fixtures\uncaught-exception-code.js ...
c:\Documents and Settings\apenneba\Desktop\src\node-qunit\lib\child.js:22
        throw err;
              ^

All tests ok.

System:

$ specs node os
Specs:

specs 0.4
https://github.com/mcandre/specs#readme

npm --version
1.2.17

node --version
v0.10.3

systeminfo | findstr /B /C:"OS Name" /C:"OS Version"
OS Name:                   Microsoft Windows XP Professional
OS Version:                5.1.2600 Service Pack 3 Build 2600
kof commented

Its actually uncaught exception test, which is testing that uncaught exceptions are registered in qunit, but it also prints it out ... didn't find how to make it better ...

@kof Oh, that's actually a useful feature :)

Maybe we should preface the exception with a message like "Throwing a test exception, disregard."

kof commented

or override the logging function just for the moment ...

@kof Yes! That would be best, as mocking it would allow the test framework to capture the output and match it to the desired value.

And please add more red colors for the errors!

screen shot 2013-11-24 at 16 38 58

kof commented

I suppose the issue has been fixed, if not please reopen.