qunitjs/node-qunit

Use qunitjs as dependency

Closed this issue · 2 comments

QUnit has a NPM ready and up-to-date package with the name qunitjs. node-qunit should use it as a dependency instead of having a hard-coded old version.

kof commented

At the time I have updated it the last time there was a reason to copy qunit into the repository. There are some small changes have been done.

That hasn't been the case since we, 2 years ago, changed that copy to be a git instead (see 673f9d6). So it's save to switch to an npm dependency.

In fact, it's more stable to do so since in more recent versions of QUnit, it is no longer just one file (it requires building from multiple source files). By using npm you can use the published version as build when it was released, and it'll be in a stable location (not subject to internal changes to the repository).