quotientbot/quotient

Render a designed HTML page for payment successful / errors.

Closed this issue · 7 comments

deadaf commented

Context: along with the bot itself we run a simple web server that handles communication with a payment gateway, most of the bot's premiums are purchased though this way only.

As you can see https://github.com/quotientbot/Quotient-Bot/blob/62ac73accd2461f3af1582143fac40bf1c4a9319/src/server/app/payment.py#L92 , we return json responses to the user be it a success event or any error, while it might be cool for the devs but not a lot of users find it creative.

We need to write some HTML , design it with some css and render the file for errors & success events in https://github.com/quotientbot/Quotient-Bot/blob/main/src/server/app/payment.py

the HTML file should be named response.html & should be inside https://github.com/quotientbot/Quotient-Bot/tree/main/src/server/templates .

what is the task?

Note that this issue will be assigned to 2-3 contributors and the best PR will be merged, you don't need to do something fancy, simple is sexy. Do share screenshots of the changes in your PRs.

deadaf commented

If you are someone looking to contribute to this project, I just created a new server to talk about issues https://discord.gg/QEdaKRDnJs

I can add a Error Page with a text place where you can add your response similarly a success page as well is that ok?

deadaf commented

Hello @basic-programmer-python , thanks for your interest!
as clearly mentioned in issue itself, there should be only one file i.e. response.html, there won't be separate files for error and success message.

You are given the liberty to design them according to you.

Hey, I have a small question. The response.html will only have success response or failure response as well. If it'll have failure response then how will if else statement work?

deadaf commented

Hello @agamswaroop619 !
See that is why I mentioned Jinja2 , its a template engine, really easy to understand, google about it.

Here's how you use can use conditionals into the HTML: https://linuxhint.com/if-statement-jinja2/
Also I mentioned the payu.html in the issue, you see how the data is being passed into the HTML Form, that is also Jinja2

Hope this helps.

can I take it @deadaf
I mean can u assign it to me?

deadaf commented

Yes you can work on it @basic-programmer-python but as mentioned in the issue, 2-3 devs will independently work on the issue and the work will be reviewed on first come basis, if you are willing to work on the issue and believe that you can finish the task, start working on it and make a PR.
(as of now 2 others mentioned to me that they will work on this)