qurator-spk/dinglehopper

Tests broken, again

mikegerber opened this issue · 4 comments

Tests ran fine after merging, so this was something related to that it was a PR.

@mikegerber , Failing tests in PRs is seemingly due to the fact that workflows triggered by pull_request event are not granted access to do certain things, e.g. to create checks as does the test-reporter here:

- name: Report tests
uses: dorny/test-reporter@v1
if: success() || failure()
with:
name: Results on Python ${{ matrix.python-version }}
path: "${{env.test_results_dir }}/junit.xml"
reporter: java-junit

We could add a separate workflow file triggered by workflow_run which could be granted access to create checks and move the above step there. Please see this and this. I would make the PR if you will.

@sadra-barikbin Yes, exactly! I will take my time to review this though, dangerous territory ;)

Should be fixed with @sadra-barikbin's PR #103, merged in 788868b!