qurator-spk/dinglehopper

No tests are run for PRs?

mikegerber opened this issue · 3 comments

mikegerber commented

#67 caused the code to fail, and the tests weren't run for the PR. Why?

kba commented

#67 caused the code to fail, and the tests weren't run for the PR. Why?

Pull requests from branches in other remotes are not tested in Circle CI by default for security reasons (they could extract secrets like passwords and tokens). You have to enable "Build forked pull requests" in the settings.

mikegerber commented

Pull requests from branches in other remotes are not tested in Circle CI by default for security reasons (they could extract secrets like passwords and tokens). You have to enable "Build forked pull requests" in the settings.

Thanks! I'll need to think about this.

mikegerber commented

Fixed in #96.

Needs more review for security: I checked the security guides and updated some settings but with this stuff it's best to look twice.