qurator-spk/dinglehopper

Review changes of #83

mikegerber opened this issue · 0 comments

I decided to merge #83 as is because of my vacation, but I had some minor changes to consider.

(List also includes things that I stumbled upon while reviewing, that were not part of #83.)

  • Review averaging of scores
  • Distinguish configuration from results - e.g. differences should be named better, perhaps show_differences
  • Add some types here and there, would have helped with differences (boolean config param) vs diff_c (the differences)
  • Consistent imports (sometimes relative, sometimes not)
  • Differences are encoding with a magic string ("Augenblick :: Augemblick"), I'd prefer tuples if that makes sense