r-lib/ellipsis

CRAN errors on recent R-devel

Closed this issue · 3 comments

echasnovski commented

This is intended as a heads-up before many upcoming errors in CRAN checks.

Starting from R-devel version "2020-05-09 r78394", CRAN checks produce errors with the same message "'where' must be an environment" (for example, see this log). This comes from base::bquote(...), which is used in ellipsis:::exit_handler(action).

Current CRAN version of 'ellipsis' has implementation of exit_handler() using bquote() with where argument being a list. Recent update in R-devel explicitly prohibited where to be anything other than environment (see this commit on R-devel). This seems to be the root cause of errors.

on_exit() implementation in development version is different and is using eval() (changed in this commit), which might have already fixed the issue, but is not yet on CRAN.

cc @hadley, @lionel- , as this seems to be important ('ellipsis' is used in 'tidyr', which has many reverse dependencies).

lionel- commented

Context: https://bugs.r-project.org/bugzilla/show_bug.cgi?id=16538

Thanks we'll prepare a release soonish.

  • 👀1
palderman commented

Prioritizing an updated release for ellipsis would be very helpful. I'm trying to submit my updated package for compliance with upcoming release of dplyr 1.0.0 (per notice from @hadley last week), but my updated code is failing checks with R-devel on r-hub.

  • 👍1
hadley commented

Fixed in 6f84df4 and now on CRAN.