r0adkll/sign-android-release

Error while Download action repository 'r0adkll/sign-android-release@v1' in github action workflow.

amaljofy opened this issue · 17 comments

amaljofy commented

Screenshot 2020-11-14 at 11 40 31 AM

Error: Could not find file '/home/runner/work/_actions/_temp_5b032fb8-b584-4bbb-acfb-d0d02db41d70/_staging/r0adkll-sign-android-release-6079bfc/node_modules/cross-spawn/node_modules/.bin/node-which'

glongchi commented

I am having the same issue as well. thanks

davwheat commented

Yep, something seems to have broken this in v1.0.3.

sainak commented

This this link points to node-which in this folder where only which is present

omeryounus commented

Yeah same here, I got the same errorr. Is there any fix for this?

r0adkll commented

Uh oh. Okay let me check this out.

r0adkll commented

@amaljofy I just pushed v1.0.4 (and updated v1) that should hopefully fix this issue.

omeryounus commented

@r0adkll thanks, Can I give it a try now?

r0adkll commented

@omeryounus yup! It should be available now

omeryounus commented

@r0adkll Awesome! Thankyou!

davwheat commented

Works perfectly!

omeryounus commented

@davwheat were you able to deploy it? did you use .APK or aab? or both

davwheat commented

@omeryounus I have 2 workflows, one for apk and one for aab.

Both completed with no issues for me.

qbalsdon commented

I used an AAB - works great! Just released my first Wear OS aab! Whoop whoop!

r0adkll commented

Excellent! I'm gonna go ahead and close this issue

  • 🎉1
foliolo commented

@r0adkll , Why didn't you update the version to v2 or similar? If you always update the v1 you will make all the builds fail when it is suppose to be stable, don't you think?
Any way, thanks so much for the quick fix!
Great job! 👏

  • 👍1
amaljofy commented

@r0adkll Great Job! Thank you so much.

r0adkll commented

@foliolo I was more or less following this guide for tagging: https://docs.github.com/en/free-pro-team@latest/actions/creating-actions/about-actions#using-tags-for-release-management. Where I just incremented these changes as a minor change (i.e. 1.0.3 and 1.0.4) and updated the accompanying major release tag v1 to point to those latest changes. The problem here is that I didn't properly test those changes and for that, I apologize.

I would recommend for anyone looking to keep their workflows stable to refer to the release tag directly (which again was my fault in the past for not keeping up with these individual version tags and just updating the major tag)

Cheers!

  • 👍2