Testing / Github revoking OAuth keys
Opened this issue · 2 comments
canweriotnow commented
When I submitted the PR for Github OAuth, I used keys for a dummy test account (typical for OAuth tests). Github has since started scanning repos for active keys and emailed me saying they'd revoked the keys for me since they were found in a public repo, so those tests should now fail.
I'm not sure if/how this will affect other services, but I have two proposals:
- Create a
credentials.properties.example
file that folks can copy tocredentials.properties
(not checked into source control) and set up their own keys there, or - Use environ and add instructions for setting env vars or values in
.lein-env
I prefer environ, but I can also see not wanting to add an external dependency for tests. Let me know if you have a preference or another idea and I'll send a pull request.
r0man commented
Hi @canweriotnow, I'm fine with environ for the tests
canweriotnow commented
Cool, I'll refactor the tests and add instructions and send a PR when I get some downtime.