rabbitholegg/quest-protocol

remove Quest.queue and QuestFactory.createQuest

waynehoover opened this issue · 4 comments

The old flow of creating a quest and then calling queue on the quest contract have been depricated. We should remove these functions and move all tests to the new createQuestAndQueue flow.

Quazia commented

Follow this pattern for the update to createQuestAndQueue

Quazia commented

There's also a Quest1155.queue() do we want to try and break down that pattern to have more parity with the standard Quest approach? That's going to be a larger chunk of work so if we want to go down that path I'll capture separately and handle that later in the week. My instinct is it's not super important to make that change now.

That's a good idea and something we should do; let's capture that work in another issue.

Fixed with #171