rabbitmq/rabbitmq-java-client

Makefile uses archived rabbitmq-codegen repository

Closed this issue · 2 comments

Describe the bug

Makefile uses the archived repository (https://github.com/rabbitmq/rabbitmq-codegen):

$(DEPS_DIR)/rabbitmq_codegen:
git clone https://github.com/rabbitmq/rabbitmq-codegen.git "$@"

Per the repo itself:

This was migrated to https://github.com/rabbitmq/rabbitmq-server

Reproduction steps

  1. Run make
  2. cd deps/rabbitmq_codegen
  3. git show remote -v shows that the old repository is used

Expected behavior

The Makefile should use the new location at https://github.com/rabbitmq/rabbitmq-server.

Additional context

No response

While it can use that repo, I don't think Makefile is really used by the core team or release infrastructure. You can point codegen.dir to the rabbitmq_codegen location and Maven will pick it up.

But I have no objections to updating Makefile target.

The Makefile is one way to get the rabbitmq_codegen dependency easily (CI uses it), so I fixed it to use the directory from the broker repository.