Makefile uses archived rabbitmq-codegen repository
Closed this issue · 2 comments
tomodachi94 commented
Describe the bug
Makefile uses the archived repository (https://github.com/rabbitmq/rabbitmq-codegen):
Lines 32 to 33 in 4b27d84
Per the repo itself:
This was migrated to https://github.com/rabbitmq/rabbitmq-server
Reproduction steps
- Run
make cd deps/rabbitmq_codegengit show remote -vshows that the old repository is used
Expected behavior
The Makefile should use the new location at https://github.com/rabbitmq/rabbitmq-server.
Additional context
No response
michaelklishin commented
While it can use that repo, I don't think Makefile is really used by the core team or release infrastructure. You can point codegen.dir to the rabbitmq_codegen location and Maven will pick it up.
But I have no objections to updating Makefile target.
acogoluegnes commented
The Makefile is one way to get the rabbitmq_codegen dependency easily (CI uses it), so I fixed it to use the directory from the broker repository.