Duplicate installations of radare-extras for each package

[sylvainpelissier]

Environment

Tue 21 Mar 10:58:43 CET 2023
radare2 5.8.5 30282 @ linux-x86-64 git.4.2.1-6563-gd6e7c1e162
commit: d6e7c1e162f5ec5b0da066f6394c8767e0592228 build: 2023-03-21__10:41:49
Linux x86_64

Description

r2pm duplicates the content of radare-extras for each package installation.

Test

$ r2pm -i vc4
INFO: Using r2-5.8.5 and r2pm-5.8.5
INFO: git clone --depth=10 --recursive https://github.com/radareorg/radare2-extras /home/sylvain/.local/share/radare2/r2pm/git//vc4
Cloning into '/home/sylvain/.local/share/radare2/r2pm/git//vc4'...
remote: Enumerating objects: 1270, done.
remote: Counting objects: 100% (1270/1270), done.
remote: Compressing objects: 100% (1090/1090), done.
remote: Total 1270 (delta 161), reused 1030 (delta 105), pack-reused 0
Receiving objects: 100% (1270/1270), 7.42 MiB | 854.00 KiB/s, done.
Resolving deltas: 100% (161/161), done.
INFO: Starting install for vc4
INFO: SCRIPT=<<EOF
INFO: 	./configure --prefix="${R2PM_PREFIX}" || exit 1
	cd libr/asm/p || exit 1
	${MAKE} clean
	${MAKE} asm_vc4.${R2_LIBEXT} || exit 1
	mkdir -p "${R2PM_PLUGDIR}" || exit 1
	cp -f asm_vc4.${R2_LIBEXT} "${R2PM_PLUGDIR}" || exit 1
INFO: EOF
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for working directories... current
using prefix '/home/sylvain/.local/share/radare2/prefix'
checking for pkg-config... Cannot find pkg-config or pkgconf in PATH

After the installation of the package vc4, the package folder contains the full radare2-extras repository:

$ ls ~/.local/share/radare2/r2pm/git/vc4
agc         binr            crashlog  jaguar-gpu  Makefile.acr    r2au       r2poke     ramoji2       ssdeep
asahi       blessr2         docker    kaitai      md380           r2elisa    r2pongo    rar           sys
Attic       checkm8         doc.sw    kdp         microblaze      r2emuhash  r2snowman  README.md     types
autogen.sh  configure       dwarf     keystone    openai          r2graph    r2svd      reil          unicorn
baleful     configure.acr   east      libr        options.mk.acr  r2ida      r2taint    rust-asm6502  world
bcl         COPYING         examples  lief        pimp            r2jadx     r2tox      scriptcraft   yara
binarly     COPYING.LESSER  iref      lua53       r2angr          r2k        r2w        slides        zpu

It is the same for each package installed and thus add unnecessary copy of radare2-extras.