rafaelmardojai/firefox-gnome-theme

[Vertical tab - Extension] Visual bug, Inconsistency

Closed this issue · 3 comments

Describe the bug
When using light theme on white-background websites, we can't see the edge of the vertical tab bar, which makes it really unaesthetically pleasing (see the screenshots).

To Reproduce

  1. Install firefox-gnome-theme using curl script
  2. Install Tab Center Reborn and copy its' firefox-gnome-theme styling from the repository
  3. Go on GitHub, or any light background website
  4. See the thing

Expected behavior
A 1px-wide separator should be present on the vertical tab bar edge to maintain visual consistency

Screenshots
Firefox New Tab
GitHub example

Setup information

  • OS: Fedora 40
  • Installation method: Curl script without sudo
  • Firefox version: 125
  • Theme version: v125 / master branch for vertical tabs styling
  • Optional features enabled: gnomeTheme.extensions.tabCenterReborn, gnomeTheme.hideSingleTab, gnomeTheme.hideWebrtcIndicator

Additional context
Tested with and without gnomeTheme.extensions.tabCenterReborn.alwaysOpen and gnomeTheme.extensions.tabCenterReborn.animationDisabled

It's indeed an issue, I will check on this very soon :)

edit: I also will try the mod on light theme from here (since I dev on dark I never checked on light)

@ataractic have made a PR to fix, in the meantime you can add this into : theme/extensions/tab-center-reborn.css and restart,

Note : I have copied the way the browser draw the line under the header bar, so I will not change the color or the size / transparency (because by coping this code it will change too if Mozilla (or this theme) decide to modify the color in the variable).

#sidebar-box{
        border-right: 0.01px solid var(--chrome-content-separator-color) !important;
}

Thank you @BirdInFire