rafaelp/css_browser_selector

IE11 not working

brentgees opened this issue · 11 comments

I tested it for ie11 on windows 7.
But I get a red window instead of a yellow window

I apologize. I have no access to IE10 or IE11. Do you have the user agent string? I have seen these by doing some searches:

IE10:
Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.1; Trident/6.0)

IE11
Mozilla/5.0 (IE 11.0; Windows NT 6.3; Trident/7.0; .NET4.0E; .NET4.0C; rv:11.0) like Gecko

No need to apologize, it's alreay great that you share it 👍
And I also did some searches and tryed it with user agent string, but that didn't work for me :/

https://github.com/WoltLab/WCF/blob/8ac2c327dd34b93db4a3041ba2ca506360fffb17/wcfsetup/install/files/lib/data/user/online/UserOnline.class.php#L169

Written in PHP, but the regular expression itself should also work in JS. It matches all IE versions, including IE11.

Hi,

if someone have time to review this patch ;)

Thanks

Yes, I will take a look. I myself have no access to IE10 or IE11. But I will take a look at this and integrate when I can.
Thanks.


From: eviweb notifications@github.com
To: rafaelp/css_browser_selector css_browser_selector@noreply.github.com
Cc: verbatim seeknosy@yahoo.com
Sent: Tuesday, November 26, 2013 7:50 AM
Subject: Re: [css_browser_selector] IE11 not working (#22)

Hi,
if someone have time to review this patch ;)
Thanks

Reply to this email directly or view it on GitHub.

FWIW I have just tested the above commit on my IE11 and it works for me.

Where is the updated code for ie 11?
I also get the string as:
Mozilla/5.0 (IE 11.0; Windows NT 6.3; Trident/7.0; .NET4.0E; .NET4.0C; rv:11.0) like Gecko

IE 11 can be tested with:
!(window.ActiveXObject) && "ActiveXObject" in window

http://stackoverflow.com/questions/21825157/internet-explorer-11-detection

This should work for detecting IE6-11 and potentially beyond.