Typo while importing a module in Community class

Question

Closed this issue 5 years ago · 3 comments

The file misc.py located in linkpred/predictors/ contains a typo while importing generate_dendrogram from the community package.

Line 24 reads from community import generate_dendogram, partition_at_level but there's a missing "r" in dendogram.

Obs: I have installed linkpred using pip install linkpred

Answer 1 · 2020-04-20T05:22:56.000Z

Thanks! It seems this function was renamed in python-louvain. We have to change it of course.

Note to myself: why wasn't this caught by any unit tests in CI?

Answer 2 · 2020-04-20T06:05:19.000Z

Ah, I now see that this was already fixed in 2487aee. I need to release a new version that includes this.

Answer 3 · 2020-04-20T20:16:22.000Z

New version 0.5.1, including this fix, now up on PyPI and just a pip install --upgrade linkpred away! 😊