rails/action_push_native

Discussions tab and gem collaboration

Opened this issue · 2 comments

  1. Would it make sense to open the 'discussions' tab on this repo? (this issue feels like something that would have been better suited for that tab)

  2. Would it make sense to share the logic for connecting with Firebase/APNs, by using separate gems for that piece?

    For example, there is a Ruby gem for connection to APNs (Apple Push Notification service):

    https://github.com/ostinelli/apnotic

    If the logic to connect with APNs (and Google equivalents) is kept in separate gems, it makes it easier to share the interoperability burden with other projects.

    That way, this gem could focus on the Rails integration, high-level models, etc. And the low-level bits of connecting with Firebase/APNs could live in separate gems and be shared with other projects.

    Sometimes Rails will inline logic that could have been kept in an external gem, where it would have been accessible to Ruby projects 'outside the web sphere'.

    Since Rails is so big in the Ruby ecosystem, that when it takes on a task, it risks choking out smaller gems with similar scope (because when Rails does it on it's own, all Rails projects will use that mechanism, but non-rails projects usually cannot piggy-back on it, because it's usually coupled with Rails).

    One positive example is image_processing -- used by ActiveStorage, but a separate gem. But just wanted to suggest following that pattern when it comes to APNs and Firebase interactions too.

    (all this said, for us we love this gem and will use ActionPush because we're building a rails app)

@brunoprietog Thanks! Updated top comment.

Again, this is mostly about the discussion's tab, so leaving this open until I've got an answer about enabling it (or if some maintainer don't want to answer, also feel free to close this issue).