rails/actionpack-page_caching

Will you accept PR that introduce brotli compression?

iggant opened this issue · 2 comments

Brotli compression looks very promising https://blogs.akamai.com/2016/02/understanding-brotlis-potential.html

So I want to enable br with gzip compression.
And want to ask can I include brotli gem as a dependence?
What is deprecation policy to arguments in the public method can I change to some more generic?

I can bump major gem version and write post install message about deprecation.
Will you consider this PR?

Should this be the responsibility of the web server in front of the Rails app?
This gem helps cache the action into static files but not sure if it should concern itself with compression methods.

I could be wrong if this can't be done at web server level.

@robzolkos generally you are right.
But, this gem already has gzip archive function.
And web servers usually use archive quality 4, due to time restrictions.
And in the gem we can use best quality 9, that will save us some additional bytes, and will bring page to user faster