Fix variant-related tests
Closed this issue · 2 comments
georgeclaghorn commented
They fail consistently in CI and on my machine, presumably due to platform differences. (MiniMagick produces different images in CI, on my machine, and on David’s machine.) I’ve temporarily skipped them in master.
/cc @dhh
colorfulfool commented
Wait, would assert_same_image ever work? JPEG is a lossy format, you can't expect images to be identical bit-to-bit.
dhh commented
Unless JPEG is not deterministic, this should have the potential to work. But of course it would need all elements held stable. Which maybe isn't right.
So probably easier we just switch to PNG for these tests instead.
… On Jul 24, 2017, at 04:52, Anton Khamets ***@***.***> wrote:
Wait, would assert_same_image ever work? JPEG is a lossy format, it produces images that look the same to humans, but they don't have to be identical bit-to-bit.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.