rails/prototype-rails

Does not looks compatible with Rails 3.1.0rc2

a-chernykh opened this issue · 10 comments

a-chernykh commented

When trying to start Rails I am getting the following error:

https://gist.github.com/1014249

I am on Mac OS X Snow Leo with ruby 1.9.2p274 (2011-06-06 revision 31932) [x86_64-darwin10.7.0]. The versions in my Gemfile:

[andrey-mbp ~/projects/rails/alt12-site rails3]$ bundle show rails
/Users/akhkharu/.rvm/gems/ruby-1.9.2-head@alt12/gems/rails-3.1.0.rc2
[andrey-mbp ~/projects/rails/alt12-site rails3]$ bundle show prototype-rails
/Users/akhkharu/.rvm/gems/ruby-1.9.2-head@alt12/gems/prototype-rails-0.3.1
kathgironpe commented

Not compatible with Rails 3.1 RC3 as well.

    from /Users/katz/.rvm/gems/ruby-1.9.2-p180/bundler/gems/prototype-rails-24ff6e3caf53/lib/prototype-rails/selector_assertions.rb:2:in `'
    from /Users/katz/.rvm/gems/ruby-1.9.2-p180/bundler/gems/prototype-rails-24ff6e3caf53/lib/prototype-rails/on_load_action_controller.rb:1:in `'
    from /Users/katz/.rvm/gems/ruby-1.9.2-p180/bundler/gems/prototype-rails-24ff6e3caf53/lib/prototype-rails.rb:8:in `block (2 levels) in '
et commented

@rubychan's fix does the trick for me.

plang commented

@rubychan's fix works for me too. Thanks!

rywall commented

Closed by #3

mhenrixon commented

I still have this problem in rails 3.1.0 RTM

from /Users/mikael/.rvm/gems/ruby-1.9.2-p290@wodstack3/gems/prototype-rails-0.3.1/lib/prototype-rails/selector_assertions.rb:2:in `<top (required)>'
from /Users/mikael/.rvm/gems/ruby-1.9.2-p290@wodstack3/gems/prototype-rails-0.3.1/lib/prototype-rails/on_load_action_controller.rb:1:in `<top (required)>'
from /Users/mikael/.rvm/gems/ruby-1.9.2-p290@wodstack3/gems/prototype-rails-0.3.1/lib/prototype-rails.rb:8:in `block (2 levels) in <class:Engine>'
mikekellyio commented

I'm running into this as well. I think the problem is that while the patch to fix it has been applied, it was applied to master and there was no version bump. Now that 3.1.0 is out, it would be good if there was an official version of this that was compatible.

mhenrixon commented

It was an easy fix, I converted every prototype script to jQuery. Took me a couple of hours!

fxn commented

The fix was pushed to master in June, and version 3.1.0 of the gem was published in August together with Rails 3.1.0. Are you still having this problem?

mikekellyio commented

I am not because I went the route @mhenrixon went and just converted it to a jQuery site. It seemed to be the path of least resistance for my particular project.

fxn commented

Perfect.

As far as I can tell this was an issue in the RCs but not in the stable releases for 3.1.x and 3.2.x, so let's close this issue.