rails/rails-dom-testing

Does this work with Rails < 4.2?

chancancode opened this issue · 3 comments

I believe this gem is only designed for 4.2+? Seems like we should at least mention that in the README, or better yet, enforce that via the gemspec. I understand that there might be some circular dep issues though.

You believe correctly. I've updated the README.

Is this what you had in mind for the gemspec?

add_dependency 'rails', '>= 4.2'

Can you elaborate on the circular dependency issues? Are you talking about Rails depending on this gem and this gem depending on Rails?

Yes to both questions 😄

I believe this gem is only designed for 4.2+?

Yes.

If we define the version here we will have circular dependency so I'd not do.

We added a warning in the README at e4a3e3b