Make assert_select take selector as a Symbol

Question

Make assert_select take selector as a Symbol

why-el opened this issue 10 years ago · 2 comments

Is there any reason why the first argument to assert_select cannot be a symbol? Will submit a quick PR if none.

Answer 1 · 2015-10-05T11:50:54.000Z

To me it's more clear that it's a selector if it's just a string. I think the gains are too small versus the mental cost of treating something that's better contained in a string as a symbol. Thanks for the suggestion though! 😄

Answer 2 · 2015-10-05T12:50:30.000Z

Sure thing, I was just surprised since this is a fairly common Rails expectation, but I can see your point with selectors. Thanks for the prompt response.