`assert_dom_equal` should default `expected` to `document_root_element`

Question

`assert_dom_equal` should default `expected` to `document_root_element`

chancancode opened this issue 9 years ago · 5 comments

chancancode commented 9 years ago

This seems consistent with the assert_select API... 👍 / 👎 ?

rafaelfranca commented 9 years ago

👍

Answer 1 · 2017-03-09T19:35:24.000Z

Sounds good to me, yeah 👍

Answer 2 · 2017-03-09T19:39:10.000Z

Hmm, on second thought. Why is it expected, we want to default document_root_element to and not actual?

Also unsure if having an *_equal assertion without 2 args would read. Consider:

assert_equal 'cheese'

How about this?

def assert_dom(expected, message = nil)
  assert_dom_equal expected, document_root_element, message
end

Answer 3 · 2017-03-09T19:48:25.000Z

Eh I totally meant actual, not expected

…

On Thu, Mar 9, 2017 at 11:39 AM Kasper Timm Hansen ***@***.***> wrote: Hmm, on second thought. Why is it expected, we want to default document_root_element to and not actual? Also unsure if having an *_equal assertion without 2 args would read. Consider: assert_equal 'cheese' How about this? def assert_dom(expected, message = nil) assert_dom_equal expected, document_root_element, messageend — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#60 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADaFfWTXl58w8KTXnetQirHlWQNpxgSks5rkFVggaJpZM4MKr_E> .

Answer 4 · 2017-03-09T20:07:24.000Z

Ha, okay, then it makes more sense 😄