rails/rails-observers

Failing test with 0.1.2

strzibny opened this issue · 0 comments

Hi,

i am getting one failure during the test suite with 0.1.2 version:

1) Failure:
ObserverTest#test_tracks_implicit_observable_models [/builddir/build/BUILD/rails-observers-0.1.2/usr/share/gems/gems/rails-observers-0.1.2/test/observing_test.rb:118]:
Expected: [Foo]
  Actual: [Foo, #<Class:0x00000005389d48>]

It's this test:

test "tracks implicit observable models" do
    instance = FooObserver.new
    assert_equal [Foo], instance.observed_classes
end

And I am unsure whether it should be failing (and fixed). It makes sense to me that the instance class is included.

The only changed I had to done was to switch to active_support/test_case which is already used in master. Here are the dependencies used during build:

DEBUG util.py:281:  Installed:
DEBUG util.py:281:    ruby.x86_64 0:2.1.2-23.fc21             ruby-libs.x86_64 0:2.1.2-23.fc21      
DEBUG util.py:281:    rubygem-minitest.noarch 0:5.3.1-2.fc21  rubygem-mocha.noarch 0:0.14.0-1.fc20  
DEBUG util.py:281:    rubygem-rails.noarch 1:4.1.4-1.fc21     rubygem-sqlite3.x86_64 0:1.3.8-2.fc21 
DEBUG util.py:281:    rubygems-devel.noarch 0:2.2.2-101.fc21 
DEBUG util.py:281:  Dependency Installed:
DEBUG util.py:281:    libyaml.x86_64 0:0.1.6-3.fc21                                                 
DEBUG util.py:281:    ruby-irb.noarch 0:2.1.2-23.fc21                                               
DEBUG util.py:281:    rubygem-actionmailer.noarch 1:4.1.4-1.fc21                                    
DEBUG util.py:281:    rubygem-actionpack.noarch 1:4.1.4-1.fc21                                      
DEBUG util.py:281:    rubygem-actionview.noarch 0:4.1.4-1.fc21                                      
DEBUG util.py:281:    rubygem-activemodel.noarch 0:4.1.4-1.fc21                                     
DEBUG util.py:281:    rubygem-activerecord.noarch 1:4.1.4-1.fc21                                    
DEBUG util.py:281:    rubygem-activesupport.noarch 1:4.1.4-1.fc21                                   
DEBUG util.py:281:    rubygem-arel.noarch 0:5.0.0-2.fc21                                            
DEBUG util.py:281:    rubygem-bigdecimal.x86_64 0:1.2.4-23.fc21                                     
DEBUG util.py:281:    rubygem-builder.noarch 0:3.2.2-2.fc21                                         
DEBUG util.py:281:    rubygem-bundler.noarch 0:1.5.2-2.fc21                                         
DEBUG util.py:281:    rubygem-erubis.noarch 0:2.7.0-7.fc21                                          
DEBUG util.py:281:    rubygem-hike.noarch 0:1.2.3-1.fc21                                            
DEBUG util.py:281:    rubygem-i18n.noarch 0:0.6.9-4.fc21                                            
DEBUG util.py:281:    rubygem-io-console.x86_64 0:0.4.2-23.fc21                                     
DEBUG util.py:281:    rubygem-json.x86_64 0:1.8.1-23.fc21                                           
DEBUG util.py:281:    rubygem-mail.noarch 0:2.5.4-2.fc21                                            
DEBUG util.py:281:    rubygem-metaclass.noarch 0:0.0.4-1.fc21                                       
DEBUG util.py:281:    rubygem-mime-types.noarch 0:1.25.1-1.fc21                                     
DEBUG util.py:281:    rubygem-multi_json.noarch 0:1.8.4-2.fc21                                      
DEBUG util.py:281:    rubygem-net-http-persistent.noarch 0:2.9.4-3.fc21                             
DEBUG util.py:281:    rubygem-polyglot.noarch 0:0.3.4-2.fc21                                        
DEBUG util.py:281:    rubygem-psych.x86_64 0:2.0.5-23.fc21                                          
DEBUG util.py:281:    rubygem-rack.noarch 1:1.5.2-3.fc21                                            
DEBUG util.py:281:    rubygem-rack-test.noarch 0:0.6.2-5.fc21                                       
DEBUG util.py:281:    rubygem-railties.noarch 0:4.1.4-1.fc21                                        
DEBUG util.py:281:    rubygem-rake.noarch 0:10.1.0-23.fc21                                          
DEBUG util.py:281:    rubygem-rdoc.noarch 0:4.1.0-23.fc21                                           
DEBUG util.py:281:    rubygem-sprockets.noarch 0:2.12.1-2.fc21                                      
DEBUG util.py:281:    rubygem-sprockets-rails.noarch 0:2.1.3-1.fc21                                 
DEBUG util.py:281:    rubygem-thor.noarch 0:0.18.1-2.fc21                                           
DEBUG util.py:281:    rubygem-thread_safe.noarch 0:0.3.3-2.fc21                                     
DEBUG util.py:281:    rubygem-tilt.noarch 0:1.4.1-1.fc21                                            
DEBUG util.py:281:    rubygem-treetop.noarch 0:1.4.14-2.fc21                                        
DEBUG util.py:281:    rubygem-tzinfo.noarch 0:1.1.0-3.fc21                                          
DEBUG util.py:281:    rubygems.noarch 0:2.2.2-101.fc21                                              
DEBUG util.py:281:    rubypick.noarch 0:1.1.1-2.fc21