Mention the "after_commit" callback in the README

Question

Mention the "after_commit" callback in the README

donv opened this issue 10 years ago · 3 comments

donv commented 10 years ago

So that new developers can know that it exists, and know when it is called.

Answer 1 · 2016-03-07T20:11:58.000Z

Feel free to submit a pull request.

Answer 2 · 2016-03-07T20:15:15.000Z

Hi @rafaelfranca !

Thanks for the quick response. I'll submit a PR, but I have one question first: Should "after_commit" be called for an update that is stopped by the "dirty" module since there were no changes? I would expect not, but I think I see this in at least one of our apps.

Just to clarify for the README change.

Answer 3 · 2016-03-07T20:20:06.000Z

If no commits are made to the database it should not run. If it is happen seems like a bug.