epics CDZ implementation: wrong order type action ?

Question

epics CDZ implementation: wrong order type action ?

rocksit opened this issue 4 years ago · 6 comments

Hello epics community,

I ask my self, if the impementation of ebics ordertype CDZ (cdz.rb) has undergone an error. Reading the ebics compendium, the order type should provide "Payment Status Report for Direct Debit". In my understanding this means an action type client "download" from ebics bank server.
But epics client.rb

def CDZ(document) upload(Epics::CDZ, document) end

implements an upload from client to bank. Is this correct ?
If so, could someone point out, why ?

regards,
Peter

Answer 1 · 2021-10-02T09:27:18.000Z

Sorry @rocksit I am currently not using or working on epics and it has been a while. :( So I don't know.
But it would be great if you can share your findings for others (or if there is an error make a PR?)

Answer 2 · 2021-11-07T17:19:11.000Z

Semantically download would make more sense similar to e.g. C53 or CRZ.
An example for an implementation of CRZ can be found in #100

Answer 3 · 2022-07-16T10:26:45.000Z

Merged now - not sure when we can get a release done though

Answer 4 · 2022-07-16T14:53:41.000Z

what is needed for the release? I can help with pinging people if needed.

Answer 5 · 2022-07-16T14:56:09.000Z

Basically we'd have to decide on a version, update the changelog and then someone has to publish the gem to be there.

I can prepare that and I believe because of the changes from #105 we wanted to go for a major version bump. So next up would be 2.0

Answer 6 · 2022-07-16T15:10:35.000Z

See #131 for prepared version bump