rainlab/builder-plugin

[Question] The plugin breaks custom validation messages for other plugins

Closed this issue · 1 comments

I noticed that my custom validation messages are being skipped and October uses its own default messages instead.

I set up validation messages by simply providing $customMessages array in my model:

    /**
     * Validation messages
     *
     * @var array
     */
    public $customMessages = [
        'name.required' => Plugin::LOCALIZATION_KEY . 'form.tags.name_required',
        'name.unique'   => Plugin::LOCALIZATION_KEY . 'form.tags.name_unique',
        'name.regex'    => Plugin::LOCALIZATION_KEY . 'form.tags.name_invalid',
        'name.min'      => Plugin::LOCALIZATION_KEY . 'form.tags.name_too_short',
    ];

I tracked down the issue and here's the problem:

image

All custom messages are being overwritten by this:

image

I see that there's a PR #265 addressing the same issue.

@LukeTowers is it going to be released soon?

@GinoPane make a PR to bump the version in version.yaml file, that'll trigger the marketplace to release the new version. Or, you can load it via composer instead.