Broken translation editing in CMS

Question

Broken translation editing in CMS

Closed this issue 4 months ago · 2 comments

acasar commented 4 months ago

This commit broke translations in the CMS: f0bb2b7

It seems that everything is saved in EN regardless of the selected site.

October version 3.5.15

Answer 1 · 2024-02-28T13:45:09.000Z

I investigated a bit. It seems that CMS calls App::setLocale in Backend\Models\Preference model:

This then triggers the 'locale.changed' event and injects CMS's locale into the Translate plugin, which is not correct. Translate plugin should use the locale from the Site context.

Answer 2 · 2024-02-28T18:13:10.000Z

Thanks, this makes sense.

Rolled back in 8b68d3a