rajasegar/alacritty-themes

This library broke alacritty and deleted my config.. ๐Ÿ‘Ž๐Ÿ‘Ž๐Ÿ‘Ž๐Ÿ‘Ž

Closed this issue ยท 10 comments

hey, @joe-narvaez I'm sorry about that ๐Ÿ™ , we may solve it did you remember what did you do when it happened?

I've had the same issue where it replaced my whole config with the alacritty-themes colors

I think we should give some sort of escape hatch to the users if we have problems like these. May be something like always creating a backup for the config file, before modifying it for preview and apply themes. So the users can just rename/move/copy the backup file to restore the settings.
@joe-narvaez @h45h1r Sincere apologies for the inconvenience caused.
@JuanVqz What are your thoughts?

Just outlining the steps here:

  • Create a backup file in the same config directory with timestamp to ensure that we are not overwriting any existing backups
  • Add documentation to README about the steps to how to restore the original config

The backup file name could be something like alacritty.yml.1655203789963.bak
so that the user can restore it by

$ mv alacritty.yml.1655203789963.bak alacritty.yml

The downside is, we will be creating a lot of backup copies. But the user can still be able to clear out these files.

The downside is, we will be creating a lot of backup copies. But the user can still be able to clear out these files.

What if you create a backup file and delete the older versions of the backup each time.

yes, I agreed. creating a backup could work.

Aside note:I think this error is showing up when you are moving between themes fast.

Aside note:I think this error is showing up when you are moving between themes fast.

Yes, I changed the theme a few times before this happened

I think we should give some sort of escape hatch to the users if we have problems like these. May be something like always creating a backup for the config file, before modifying it for preview and apply themes. So the users can just rename/move/copy the backup file to restore the settings.

@joe-narvaez @h45h1r Sincere apologies for the inconvenience caused.

@JuanVqz What are your thoughts?

@rajasegar I'm thinking users will end up in the same scenario if we create a backup each time they select a new theme. We may create corrupt backups.

What about to add the option: alacritty-themes --backup and let them use it when they want.

No no, not each time they select a new theme, but only one time when they invoke the program even before showing the prompts.

No no, not each time they select a new theme, but only one time when they invoke the program even before showing the prompts.

sounds good! I'll check it