rajasegar/alacritty-themes

making backup doesnt support all linux config paths

Closed this issue ยท 5 comments

Descibe the bug

If alacritty config file is not $HOME/.config/alacritty/alacritty.yml, (in my case it is $HOME/.alacritty.yml) it will throw an error

Steps to reproduce

  1. Installation:
    • installed using npm i -g alacritty-themes
  2. Running:
    • just ran alacritty-themes

Expected Behavior

Running normally, without errors

Operating System

Arch Linux (Manjaro)

Screenshots

alac-bug

I've looked around the source code a bit. Looks like the problem is from createBackup function. On Linux, when it checks if the config exist, it will check both $HOME/.config/alacritty/alacritty.yml and $HOME/.alacritty.yml. But when it creates a backup file it will always use $HOME/.config/alacritty/alacritty.yml

good call! I assumed the alacritty.yml file was located at $HOME/.config/alacritty/alacritty.yml, I don't like the idea of creating backups in the $HOME directory thought ๐Ÿค”

The solution may be use this function

function alacrittyConfigPath() {
instead of
function pathToAlacrittyFile() {

do you want to fix it?

Thanks! But as you said, creating backup files in home direcotry is not really a neat solution. I think fixing this bug needs an oponionated solution which is beyond me.๐Ÿ™‚

a quick and good solution could be, even if the alacritty.yml file is in the $HOME directory we will create the backups files in this path $HOME/.config/alacritty/

I just fixed the alacritty path, please download the latest version of alacritty-themes to get it working on your end ๐Ÿ‘

Thanks for reporting it

๐ŸŽ‰ This issue has been resolved in version 5.0.1 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€