making backup doesnt support all linux config paths
Closed this issue ยท 5 comments
Descibe the bug
If alacritty config file is not $HOME/.config/alacritty/alacritty.yml
, (in my case it is $HOME/.alacritty.yml
) it will throw an error
Steps to reproduce
- Installation:
- installed using
npm i -g alacritty-themes
- installed using
- Running:
- just ran
alacritty-themes
- just ran
Expected Behavior
Running normally, without errors
Operating System
Arch Linux (Manjaro)
Screenshots
I've looked around the source code a bit. Looks like the problem is from createBackup function. On Linux, when it checks if the config exist, it will check both $HOME/.config/alacritty/alacritty.yml
and $HOME/.alacritty.yml
. But when it creates a backup file it will always use $HOME/.config/alacritty/alacritty.yml
good call! I assumed the alacritty.yml
file was located at $HOME/.config/alacritty/alacritty.yml
, I don't like the idea of creating backups in the $HOME directory thought ๐ค
The solution may be use this function
alacritty-themes/src/helpers/index.js
Line 85 in 4519540
alacritty-themes/src/helpers/index.js
Line 61 in 4519540
do you want to fix it?
Thanks! But as you said, creating backup files in home direcotry is not really a neat solution. I think fixing this bug needs an oponionated solution which is beyond me.๐
a quick and good solution could be, even if the alacritty.yml
file is in the $HOME directory we will create the backups files in this path $HOME/.config/alacritty/
I just fixed the alacritty path, please download the latest version of alacritty-themes to get it working on your end ๐
Thanks for reporting it
๐ This issue has been resolved in version 5.0.1 ๐
The release is available on:
Your semantic-release bot ๐ฆ๐