ranyitz/globitor

Add an option for ignoring .gitignore

Closed this issue · 4 comments

kristian commented

Hey @ranyitz, I really like the interactive design of your package! It would be super helpful to me, however I try to glob files which are in my .gitignore. It would be super helpfull to have an option to NOT gitignore things like:

npx globitor --no-gitignore

... or similar. What do you think? Thanks!

ranyitz commented

@kristian thanks! That's a great idea. Would you like to contribute a PR with this change?

Just to make it clearer to contribute i'll add the places that require a change:

  1. Addition of the flag to the CLI app
  2. Adjust the --help
  3. Passing of the flag from the cli to this call
kristian commented

I never worked much with typescript before, so please have a look before merging. Hope the change is fine, if not let me know!

  • 👍1
ranyitz commented

Sure, I reviewed the PR, let's continue the discussion there

kristian commented

Thanks @ranyitz. Are you going to release it also to NPM? That'd be hepful! Thanks & have a good one!