FeedBack - Code

[c0ncentus]

hi !

This package is awesome so, i forked it and wanted to put 0 dependencies.

I add typescript on this js package (2) [...].

well... I don't want make pull request because want to make some custom stuff with borders (babylon 5 map)

export interface GeoBorderProps {
    wikidata?: string;
    nameEn?: string;
    aliases?: string[];
    country?: string;
    groups?: string[];
    driveSide?: "right" | "left";
    roadSpeedUnit?: "mph" | "km/h";
    roadHeightUnit?: "ft" | "m";
    callingCodes?: string[];
    iso1A2?: string,
    iso1A3?: string
    level?: GeoLevel,
    m49?: string,
    iso1N3?: string,
    isoStatus?: "usrAssn" | "excRes" | "official",
    ccTLD?: string,

    emojiFlag?: string,
    members?: string[],
    maxLevel?: string | undefined;
    withProp?: string | undefined;
    id?: string,
}
export type GeoBorderKeys= keyof GeoBorderProps

• This package dont exploit the power of typescript ... rather makes 7*2 functions, you can add a parameter ...
• the names of function is confusing ... make it more clear (like "filter...", "search...", find....)
• +surcharge data is a mistake ... In order to be efficient make id with geometry and extra info on a object which have id /props ... geometry is too heavy in my opinion ...
• When user make search in object you dont have to retrieve the coord of multipolygon/polygon so the props is more usefull than feature ...

I hope it helps

[bhousel]

Thanks! Sorry to say I also find the package hard to work with. 😆