rappasoft/laravel-livewire-tables

[Bug]: setQueryStringDisabled is not working

jacksontong opened this issue · 4 comments

jacksontong commented

What happened?

I have called setQueryStringDisabled on the configure method but it has no effect.
image

If I set $queryStringStatus = false; then it works.

How to reproduce the bug

public function configure(): void
{
    $this->setPrimaryKey('id');
    $this->setQueryStringDisabled();
}

Package Version

dev-v3-develop

PHP Version

None

Laravel Version

10

Alpine Version

No response

Theme

None

Notes

No response

Error Message

No response

lrljoe commented

Thanks for raising, I'll look into this shortly :)

lrljoe commented

Plan for this is to:

  1. Migrate current queryString into the appropriate traits
  2. Fix the global disable/enable
  3. Enable simple enable/disable on a per-trait basis (i.e. enable/disable queryString for search/filter/columnselect/sort)

Expect this fix by early November

  • 👍1
lrljoe commented

Tasks 1 & 2 for this are done, and I'm just doing some final tests on it, expect it this weekend, ahead of an initial stable release. See PR #1465

Task 3 - I've raised a Feature Request for rather than a bug, as it's "new functionality" to enable/disable them individually

lrljoe commented

Task 1 &2 are in beta 10.

Task 3 is captured separately.

Please advise if anything is not working relation to this