rasbt/LLMs-from-scratch

GitHub's image rendering issue

rasbt opened this issue · 5 comments

rasbt commented

Bug description

GitHub's image rendering in Jupyter notebooks unfortunately broke last week. This means that the Jupyter Notebooks are viewed in this repository are not displayed correctly and show as missing images.

Two solutions in the meantime are

  1. View the Jupyter files locally after cloning the repository
  2. View the Jupyter files online via https://nbviewer.org

I will give it approximately a week, and if it still doesn't work, I will consider adding the image files to this GitHub repo directly. (I originally wanted to avoid this because this will add another ~10 Mb to the repository.)


More information

For those who are interested in more information about this issue, I created a test repo here where you can see that the images (png, jpg, webp) work fine when embedded in a Markdown file.

However, in Jupyter Lab files, the same images don't render anymore since last week.

However, Jupyter Lab files still render the images if they are inserted via relative links. So, I suspect that their image caching service for notebooks broke.

Since this issue is persisting for 4 days now, I also filed a bug report on GitHub here. Hopefully someone will investigate.

rasbt commented

The GitHub support team got back to me and was able to confirm the issue. They are currently investigating (cc @d-kleine)

  • 👍1
rasbt commented

Seems like they finally fixed it 😊

  • 👍1
d-kleine commented

Nice!

d-kleine commented

If you like to have the original image links back again, you could just simply git revert the commit bash where you have changed the image links to the nbviewer links 🙂

rasbt commented

Good point, I reverted the links

  • 👍1