Timezone name has no trailing space
coolum001 opened this issue · 2 comments
Hi
First of all, thank you for this package:
Second, I believe the Timezone name option is missing a trailing space.
%watermark -z -i
E. Australia Standard Time2019-08-14T15:37:07+10:00
This running in an environment as follows:
2019-08-14T15:32:43+10:00
CPython 3.7.1
IPython 7.2.0
compiler : MSC v.1915 64 bit (AMD64)
system : Windows
release : 10
machine : AMD64
processor : Intel64 Family 6 Model 94 Stepping 3, GenuineIntel
CPU cores : 8
interpreter: 64bit
Looking at the code, I find
if args.timezone:
self.out += strftime('%Z')
where most other constructed strings have a trailing newline or space.
Happy to supply more information if needed
Don
Hi Don,
since combining the local timezone and the time zone in the ISO 8601, this would be a unusual combination which is why I never checked for this :P. Thanks for the note, and this should obviously be fixed wrt to the trailing whitespace.
Now, looking at the code I think the whole current trailing whitespace thing is not handled very elegantly. In any case, I'd appreciate a PR -- otherwise, it would also not be a problem for me to fix that, just let me know.
Hi
sorry for delayed reply: My grasp of GIT is a bit rudimentary, so it might be best not to wait for a PR from me :) . This issue I don't see as major, so happy to wait till you can roll a patch in, when ever you can get around to it.
Thanks again
Don