Is the keepalive fired per connection?

Question

Is the keepalive fired per connection?

rdrey opened this issue 8 years ago · 3 comments

I had just a quick look at the code, so I could be reading it wrong, but it looks like it just sends a keepalive for one of the connections in the pool per interval. Could you fix it?

Answer 1 · 2016-09-22T16:43:06.000Z

I would be happy to contribute a PR, too. For my use case at least the keepalive timer can be reset every time a message was successfully sent/received.

Answer 2 · 2016-09-23T07:17:35.000Z

The keepalive is sent to all connections in the pool. The contextmanager is written to rotate among them, which is a good thing even for normal usage (in addition to keepalive

Answer 3 · 2016-09-23T11:06:55.000Z

Ah, I didn't spot this. Yeah, it's good enough for me. 👍

    delay = float(self.keepalive) / self.size