csi-* images are outdated, invalid build.make.patch failing builds
zamnuts opened this issue · 0 comments
Details
What steps did you take and what happened:
During a recent rook-ceph install, I was verifying CSI image versions in raspbernetes compared with their upstreams on quay (kubernetes-csi publishes to both GCR and quay*). All CSI images were outdated. Originally I thought it was just one, so opened PR #204 to fix csi-external-resizer, and then only afterwards realized all were failing for the same reason:
#18 3.306 patching file release-tools/build.make
#18 3.306 Hunk #1 FAILED at 74.
#18 3.307 1 out of 1 hunk FAILED -- saving rejects to file release-tools/build.make.rej
Image list and their respective failed runs:
- csi-external-attacher, run #41, quay v3.1.0, r10s 3.0.0
- csi-external-provisioner: run #55, quay v2.1.0, r10s 2.0.2
- csi-external-resizer (See PR #204): run #40, quay v1.1.0, r10s 1.0.0
- csi-external-snapshotter: run #57, quay v2.1.4 v3.0.3 v4.0.0, r10s 2.1.1 3.0.0
- csi-node-driver-registrar: run #38, quay v2.1.0, r10s 2.0.1
All builds failing :)
What did you expect to happen:
Stay up-to-date for the following images:
- csi-external-attacher
- csi-external-provisioner
- csi-external-resizer
- csi-external-snapshotter
- csi-node-driver-registrar
All builds to succeed :)
Anything else you would like to add:
I'd be happy to contribute individual fixes for each in unique PRs, but am unsure how to test / don't have the means. I'd like to get PR #204 through first to see it successfully publish (and work as expected), before contributing the other PRs. I'm unsure if build.make is the only problem. LMK if you want these in distinct PRs, or clubbed under one, given that it appears to all be the same bug.
Additionally, it looks like the last few versions are missing, despite some of the .version files being updated. We can get the fix in, then make incremental commits to fill in the missing raspbernetes published versions, or just publish the latest and consider the ones missing gone forever.