rastapasta/react-native-gl-model-view

Release build failing

Closed this issue · 3 comments

While building a production release (1st time) I get an error. But works fine on development environment. Can @rastapasta @PatriceVignola @cawfree you please guide me on this and let me know what the issue is?

Task :react-native-gl-model-view:verifyReleaseResources FAILED
FAILURE: Build failed with an exception.

  • What went wrong:
    Execution failed for task ':react-native-gl-model-view:verifyReleaseResources'.

java.util.concurrent.ExecutionException: com.android.builder.internal.aapt.v2.Aapt2Exception: Android resource linking failed
..\node_modules\react-native-gl-model-view\android\build\intermediates\res\merged\release\values-v28\values-v28.xml:7: error: resource android:attr/dialogCornerRadius not found.
..\node_modules\react-native-gl-model-view\android\build\intermediates\res\merged\release\values-v28\values-v28.xml:11: error: resource android:attr/dialogCornerRadius not found.
..\node_modules\react-native-gl-model-view\android\build\intermediates\res\merged\release\values\values.xml:2714: error: resource android:attr/fontVariationSettings not found.
..\node_modules\react-native-gl-model-view\android\build\intermediates\res\merged\release\values\values.xml:2715: error: resource android:attr/ttcIndex not found.
error: failed linking references.

Error

Hi @Amjad675 , I believe this could be related to your compileSdkVersion.

Thanks for the reply @cawfree I was able to figure out the issue. Unfortunately the android/build.gradle file of react-native-gl-model-view has compileSdkVersion set to 27 which is the cause for the issue. Once I edited it to compileSdkVersion rootProject.hasProperty('compileSdkVersion') ? rootProject.compileSdkVersion : 28 it built successfully.

Can the contributors kindly update the android/build.gradle file so that we won't have to come across this issue again? @rastapasta @PatriceVignola

Aloha @Amjad675 & @cawfree - thanks a lot for checking in!

The build.gradle got updated accordingly and will be included in the next release tonight. Cheers!