ratt-ru/QuartiCal

Misleading chi-squared values when `output.subtract_directions` is in use.

Closed this issue · 1 comments

Describe the bug
Misleading/incorrect chi-squared values when output.subtract_directions is in use. This is because the post-solve chi-squared values are computed using the residual which in turn is affected by output.subtract_directions. The solution is already partially in place in #212 which also reduces memory footprint.

To Reproduce
Run a DD calibration with output.subtract_directions set to a subset of directions.

Expected behavior
Chi-squared values should decrease/remain the same in places where gain solutions where successful.

Version
main

Fixed by #212.