Are we getting too many CLI arguments?

Question

Are we getting too many CLI arguments?

gitolicious opened this issue 4 years ago · 4 comments

The current master branch scipt already has 14 CLI arguments. With the currently open PRs (#81, #83) it will be at least five more and I have plenty more in my mind. Looks like this is slowly getting out of hand. Should we switch to a config file? Any other ideas? Or just keep them coming?

Answer 1 · 2021-06-21T06:49:57.000Z

Hello Gitolicious,

You are right there are many arguments. However, mostly when you use doctoshotgun for someone, this is… a one shot. So command line arguments are appropriate. We can keep CLI arguments, and add another one to parse a config file :)

Answer 2 · 2021-06-21T06:52:24.000Z

There are currently too many opened PRs, the problem is that it complexifies the code, and some of them are incompatibles ou redundant… I have to take time to uniformise them.

Answer 3 · 2021-06-21T15:28:57.000Z

In an ideal world, the script is a "one shot" (what a pun...) but in Germany currently it is really hard to find a doctor who offers appointments so you have to experiment a lot with the settings.

For PR reviews: they should be much easier and quicker when test coverage is higher as proposed in #73.

Answer 4 · 2021-07-05T20:09:55.000Z

I had a quick play with a config file implementation but ultimately found it too much effort and got used to the CLI argument combination. Will close this for now until others jump in and are asking for the feature as well.