Support both Jekyll and Bridgetown
Opened this issue · 1 comments
Hello! Thank you very much for your plugin!
I have been using it in my Jekyll website for a long time, until I migrated to Bridgetown. Both tools are great for static website generation, just Jekyll doesn't meet my requirements anymore. Bridgetown meets them better, but unfortunately, it doesn't have plugin like this yet, so dealing with images in the right way is somewhat difficult.
That's why I forked this plugin to adopt it for Bridgetown and to make my website work as before (piece of advertisement: My experience of Jekyll -> Bridgetown migration): bridgetown_picture_tag. The only change I made is the interaction with the engine, while the core logic remained untouched. I'm not an experienced Ruby developer and I don't know how to do things correctly here, in Ruby world, so I will not support my fork a lot, especially since I also believe there is a way to make your plugin engine-independent, at least to make it work both on Jekyll and Bridgetown. Additionally, I saw that you already thought about this 4 years ago.
I think I'm not the only one who requires such plugin on Bridgetown, so it would be great if you could manage to make these changes here.
This is amazing, I've been interested in accomplishing something like this for awhile but I didn't have the time to invest in actually solving it. Thank you for taking the time and effort to research and solve the problem!
I'm definitely thinking there should be two separate gems, one for jekyll and one for bridgetown. I should probably extract the core logic to its own gem which the others will share, but for now a simple fork like you've done will do the job.
Could you talk me through what changes you actually needed to make it work? I looked through your fork and there are a lot of formatting changes in the same commit so it's hard to pick out the meaningful differences.