Debug value left in release?

Question

Debug value left in release?

Closed this issue 2 years ago · 8 comments

Not sure if it's just my implementation but there seems to be a temp debug value left in the release:

Answer 1 · 2023-01-05T23:55:18.000Z

I don't control what goes there. On my machine, the current temperature is on the left, and the set temp is on the right:

I know that there were some recent changes to the water heater integration, but I don't know if that's changed as I never look there.

Answer 2 · 2023-01-06T17:16:21.000Z

I never actually look at the more-info or state display like that, but if it changed, the only related change that I see is this. The actual output is actually generated here, but that only changed to support the state localization changes to ComputeStateDisplay.

Answer 3 · 2023-01-10T01:01:57.000Z

BTW, I filed home-assistant/frontend#15066 for it. Let's see what happens, but it looks like it's been that way since at least 2018 based on the git history.

Answer 4 · 2023-01-10T17:36:35.000Z

Turns out it is my fault, based on an intentional decision to publish the current temperature as the state rather than the ones mentioned in the docs that don't have a useful meaning here. I guess I can just make it "STATE_ELECTRIC" 🤷 . I think that has implications for the cards that I'm using in the frontend, though.

Answer 5 · 2023-01-10T17:42:26.000Z

It doesn't work work with a card I'm using, but I guess I can "fix" it, too.

Answer 6 · 2023-01-10T18:08:21.000Z

Released v0.9.7 to add better debug logging and fix the water_heater entity state. No matter whether you (or I) actually like the change, it's at least correct based on the docs now.

Answer 7 · 2023-01-10T21:32:11.000Z

Thanks for looking at it. It makes more sense now and turned out to be far more complex than I thought! I was thinking/hoping it was just a debug value!

Answer 8 · 2023-01-10T21:52:18.000Z

As with many issues, it was a super-simple change in the code.