pyrgov upadates for new checkBalance.rho

Question

pyrgov upadates for new checkBalance.rho

Closed this issue 3 years ago · 4 comments

w2vy commented 3 years ago

The modified rho file caused errors in pyrgov

Answer 1 · 2021-07-05T18:36:39.000Z

Is this a bug? If so, what are the symptoms? What are the steps to reproduce it?

Answer 2 · 2021-07-05T19:05:00.000Z

@w2vy
You definitely know the testing framework better than anyone else. Can you put up a screenshot or log please?

Answer 3 · 2021-07-05T19:11:14.000Z

@dckc @jimscarver @w2vy
I think I understand this better now.
We need to update CONTRIBUTING.md (or somewhere) so require changes of rholang actions to pass the integration tests before merge. Either 1) @w2vy needs to be on all rholang action reviews, or 2) integration tests need to be updated/passed before merge.

Answer 4 · 2021-07-06T11:01:01.000Z

In pyrgov.py it would fail on line 76 (raise an exception)
contract = string.Template(template).substitute(substitutions)

Because the rholang (template) would appear to have $var that was not offered a substitution.

This is fixed by PR 216